Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor docker runner: new logging system and fixed several bugs #17542

Open
wants to merge 15 commits into
base: develop2
Choose a base branch
from

Conversation

perseoGI
Copy link
Contributor

@perseoGI perseoGI commented Dec 31, 2024

Changelog: Feature: Fix several bugs in docker runner, added new configuration options and improved logging system
Docs: conan-io/docs#3977

  • Homogeince logs with the the rest of the runners
  • Add new configuration options such as defining docker platform from configfile and directly from profile -> this allows defining platform such as linux/amd64 on Mac Silicon systems, avoiding compilation issues related with architecture
  • Rearrange and improve the readability of code.
  • Fix minor bugs while reading profiles
  • Renamed profile options to have docker. prefix to avoid collisions with other runner configurations
  • Fix [bug] docker runner doesn't work when conanfile is inside subfolder #17746

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@perseoGI perseoGI requested a review from davidsanfal December 31, 2024 09:05
@perseoGI perseoGI marked this pull request as ready for review January 2, 2025 10:50
@perseoGI perseoGI changed the title Refactor docker runner, updated logging Refactor docker runner: new logging system and fixed several bugs Jan 31, 2025
conan/internal/model/conf.py Outdated Show resolved Hide resolved
test/functional/command/runner_test.py Outdated Show resolved Hide resolved
conan/internal/model/conf.py Outdated Show resolved Hide resolved
conan/internal/runner/docker.py Outdated Show resolved Hide resolved
conan/internal/runner/output.py Outdated Show resolved Hide resolved
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] docker runner doesn't work when conanfile is inside subfolder
3 participants