Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding premake to CI #17765

Merged
merged 2 commits into from
Feb 13, 2025
Merged

adding premake to CI #17765

merged 2 commits into from
Feb 13, 2025

Conversation

memsharded
Copy link
Member

Changelog: Omit
Docs: Omit

Just provision Premake in CI, only in Linux at the moment.

To prepare CI for #17398

Comment on lines +152 to +154
RUN wget https://github.com/premake/premake-core/releases/download/v5.0.0-beta4/premake-5.0.0-beta4-linux.tar.gz && \
tar -xvzf premake-5.0.0-beta4-linux.tar.gz && chmod +x premake5 && mkdir /usr/share/premake && \
mv premake5 /usr/share/premake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's declare above something like:

BAZEL_8=8.0.0 \
PREMAKE_5=5.0.0

So we can use it here as:

RUN wget https://github.com/premake/premake-core/releases/download/v${PREMAKE_5}-beta4/premake-${PREMAKE_5}-beta4-linux.tar.gz && \
    tar -xvzf premake-${PREMAKE_5}-beta4-linux.tar.gz && chmod +x premake5 && mkdir /usr/share/premake && \

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't plan to add or support more than 1 premake version in Conan and CI, do you think it is still necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all 👍

@franramirez688 franramirez688 merged commit 0455fd6 into develop2 Feb 13, 2025
34 checks passed
@memsharded memsharded deleted the memsharded/feature/add_premake branch February 13, 2025 11:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants