Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow filtering in or out commits based on strings within commit message #263

Merged
merged 6 commits into from
Jul 29, 2019

Conversation

eliotstocker
Copy link
Contributor

@eliotstocker eliotstocker commented May 30, 2019

It was a requirement to be able to filter in/out release commits for a pipeline we have been working on.
this should allow a lot of customization in the way of skipping commits etc based on commit message

Eliot Stocker added 5 commits May 31, 2019 10:16
…s like mentioned in concourse#215

Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
@eliotstocker
Copy link
Contributor Author

This should also mostly address: #215

Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, and sorry for the wait!

I continue to be super worried about the hairiness of our Bash code, but that's a battle for another day. There are tests covering it and all the other tests pass, so all I can do is trust them.

Minor changes requested.

README.md Outdated Show resolved Hide resolved
assets/check Outdated Show resolved Hide resolved
Signed-off-by: Eliot Stocker <estocker@brandwatch.com>
@eliotstocker
Copy link
Contributor Author

eliotstocker commented Jun 7, 2019

Changes Applied 😄

@jakubikan
Copy link

jakubikan commented Jul 22, 2019

any update on this?

I could have a use case on running a pipeline on certain commit messages.

@vito no pressure 😸, but any idea when this will be merged?

Copy link
Member

@vito vito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait!

@vito vito merged commit e009b90 into concourse:master Jul 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants