Create a branch dedicated to builds of ArcticDB against libevent 2.1.10
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.09.24.21.36.48
See: conda-forge#61 (comment) Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.09.24.21.36.48
jjerphan
requested review from
DerThorsten,
JohanMabille,
alexowens90,
jamesmunro,
mehertz,
phoebusm,
poodlewars,
qc00 and
vasil-pashov
as code owners
h-vetinari
reviewed
Sep 25, 2023
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: h-vetinari <h-vetinari@users.noreply.github.com>
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.09.26.03.46.41
jjerphan
changed the title
libevent 2.1.10
JohanMabille
approved these changes
Sep 26, 2023
This was referenced Sep 27, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Context
Builds of ArcticDB against libevent 2.1.10 are currently needed by some users of ArcticDB. On
main,there is a build variant configuration to build ArcticDB againstlibevent 2.1.10andlibevent 2.1.12, but this causes several problems for conda-forge (see #60 for an overview of them).This PR (which aims at starting the maintenance of another branch named
libevent-2.1.10) would unlock conda-forge's migration bot as mentioned by @h-vetinari in #60 (comment). Once it is merged,libeventcan be unpinned from the configuration.The channel will remain the default and ArcticDB will continue to be installable as it is actually the case with, that is with:
This solution is courtesy of @jamesmunro, and was mentioned to be effective by @h-vetinari in discussions we had.
Since those builds are going to be uploaded on a dedicated channel, I am not updating the build number (it could be reset to 0), but I prefer to keep it in sync with the one on
main. We will then need to updatemainand this newlibevent-2.1.10branch synchronously.@h-vetinari: can you explicitly approve this PR if this resolves the afore-referenced problem? Thank you.