Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate to {{ stdlib("c") }} #17

Merged
merged 2 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conda-forge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ github:
tooling_branch_name: main
os_version:
linux_64: cos7
linux_aarch64: cos7
Comment on lines 9 to +11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variants for linux-64 are unchanged as that was already using CentOS 7

Similarly variants for linux-aarch64 are unchanged as this is the default

Plus conda-smithy was always adding c_stdlib before ( conda-forge/conda-smithy#1888 ). Hence why those values are already filled out. Of course conda-smithy no longer adds c_stdlib ( conda-forge/conda-smithy#1908 ). Though as we add {{ stdlib("c") }} in this PR, we keep it throughout

All this to say the changes here are working as expected even though the diff is a bit lighter

provider:
linux_aarch64: default
10 changes: 5 additions & 5 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ source:
sha256: 5db80b1905b3fe25a07f29462c8694af1375834c1d8e7b6bf4cf4ffbb8c0b934 # [aarch64]

build:
number: 1
number: 2
binary_relocation: false
skip: true # [not (linux64 or aarch64)]

Expand Down Expand Up @@ -55,7 +55,7 @@ outputs:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- arm-variant * {{ arm_variant_type }} # [aarch64]
- sysroot_{{ target_platform }} 2.17 # [linux]
- {{ stdlib("c") }}
- {{ cdt("rdma-core-devel") }} # [linux64]
- patchelf <0.18.0 # [linux]
host:
Expand Down Expand Up @@ -90,7 +90,7 @@ outputs:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- arm-variant * {{ arm_variant_type }} # [aarch64]
- sysroot_{{ target_platform }} 2.17 # [linux]
- {{ stdlib("c") }}
host:
- cuda-version {{ cuda_version }}
run:
Expand Down Expand Up @@ -125,7 +125,7 @@ outputs:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- arm-variant * {{ arm_variant_type }} # [aarch64]
- sysroot_{{ target_platform }} 2.17 # [linux]
- {{ stdlib("c") }}
host:
- cuda-version {{ cuda_version }}
run:
Expand Down Expand Up @@ -154,7 +154,7 @@ outputs:
- {{ compiler("c") }}
- {{ compiler("cxx") }}
- arm-variant * {{ arm_variant_type }} # [aarch64]
- sysroot_{{ target_platform }} 2.17 # [linux]
- {{ stdlib("c") }}
host:
- cuda-version {{ cuda_version }}
- libcufile-dev {{ version }}
Expand Down