Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

minizip v4.0.7 #17

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@akrherz
Copy link
Contributor

akrherz commented Jun 15, 2024

Windows failure appears to be the lib rename from zlib-ng/minizip-ng#778

@akrherz akrherz added the automerge Merge the PR when CI passes label Jun 15, 2024
@github-actions github-actions bot merged commit 868d4b6 into conda-forge:main Jun 15, 2024
8 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 4.0.7_hf51570 branch June 15, 2024 21:44
@martinfleis
Copy link

Windows failure appears to be the lib rename from zlib-ng/minizip-ng#778

This is now causing downstream CI (and likely all windows environments) depending on minizip via GDAL to fail. For example the only difference in environments between this and this is the minizip version being bumped from 4.0.6 to 4.0.7. Is that expected? If so, where should the patch happen? In gdal-feedstock? I have to admit this is too far from what I'm familiar with but my investigation of our CI failures led me directly here.

@lachlanhurst
Copy link

This is now causing downstream CI (and likely all windows environments) depending on minizip via GDAL to fail....

Seeing the GDAL problem here. Pinning to minizip 4.0.6 fixes the issue.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 17, 2024

@akrherz let's mark this version as broken until we figure out a better path forward.

@akrherz
Copy link
Contributor

akrherz commented Jun 17, 2024

My understanding is that on windows, upstream renamed libminizip.dll to minizip.dll and with the example build log

warning  libmamba [minizip-4.0.7-h52f1734_0] The following files were already present in the environment:
   - Library\include\minizip\ioapi.h
    - Library\include\minizip\unzip.h
    - Library\include\minizip\zip.h
     - Library\lib\minizip.lib

that minizip.lib is a new conflict. So I think conda-forge/libkml-feedstock#2 becomes a more pressing problem? Marking as broken is fine. I am on vacation at the moment, but I think I can get to that shortly.

@ocefpaf
Copy link
Member

ocefpaf commented Jun 17, 2024

My understanding is that on windows, upstream renamed libminizip.dll to minizip.dll and with the example build log

warning  libmamba [minizip-4.0.7-h52f1734_0] The following files were already present in the environment:
   - Library\include\minizip\ioapi.h
    - Library\include\minizip\unzip.h
    - Library\include\minizip\zip.h
     - Library\lib\minizip.lib

that minizip.lib is a new conflict. So I think conda-forge/libkml-feedstock#2 becomes a more pressing problem? Marking as broken is fine. I am on vacation at the moment, but I think I can get to that shortly.

I can do that. Enjoy your vacation!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants