Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New version 2.6.1 #13

Merged
merged 3 commits into from
Mar 5, 2024
Merged

New version 2.6.1 #13

merged 3 commits into from
Mar 5, 2024

Conversation

benvial
Copy link
Contributor

@benvial benvial commented Mar 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: jaxlib=*=*cuda* must contain a space between the name and the pin, i.e. jaxlib =*=*cuda*

For recipe:

  • Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.
  • Please depend on pytorch directly. If your package definitely requires the CUDA version, please depend on pytorch =*=cuda*.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: jaxlib= *=*cuda* must contain a space between the name and the pin, i.e. jaxlib =*=*cuda*

For recipe:

  • Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.
  • Please depend on pytorch directly. If your package definitely requires the CUDA version, please depend on pytorch =*=cuda*.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Please depend on pytorch directly, in order to avoid forcing CUDA users to downgrade to the CPU version for no reason.
  • Please depend on pytorch directly. If your package definitely requires the CUDA version, please depend on pytorch =*=cuda*.

@benvial benvial merged commit ce7ed3e into conda-forge:main Mar 5, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant