Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix cuda-version dependency to use CUDA enhanced compatibility for CUDA 11 and CUDA 12 #111

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

dantegd
Copy link
Contributor

@dantegd dantegd commented Jul 29, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@dantegd dantegd changed the title Fix cuda-version decpendency to use CUDA enhanced compatibility for CUDA 11 and CUDA 12 Fix cuda-version dependency to use CUDA enhanced compatibility for CUDA 11 and CUDA 12 Jul 29, 2024
@dantegd dantegd marked this pull request as ready for review July 29, 2024 19:48
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dantegd
Copy link
Contributor Author

dantegd commented Jul 29, 2024

@leofang leaving this here as well for reference, I tested nccl with cuML and RAFT on CUDA 11.4, and things work well

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants