-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
0.10.0 build 1 and examples package #9
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@j-wags I got it working! With this PR, there is a My questions:
|
To keep things in one place -- Discussion and next steps are in today's meeting notes |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
*Wipes sweat from brow Added the test checking that the installed file tree matches the source tree. It seems to be working! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should let us test from a branch of the toolkit -- We need to make sure to point this back to the release URL before we merge!!
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is all updated and working with the latest version of the examples helper as of this comment. PR for the helper: openforcefield/openff-toolkit#934 I did notice that the packages all still depend on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for all the iterating on this @Yoshanuikabundi!
I think we need to merge this BEFORE the next release. As long as we revert the version+build, there shouldn't be any packages built or tests run. I'll give it a shot now :-)
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.05.12.18.50.42
@conda-forge-admin, please rerender |
…nda-forge-pinning 2021.08.02.13.50.20
The
openff-toolkit
repository has a number of example notebooks that demonstrate its use, and we're about to put a bunch of effort into improving them and adding more. In openforcefield/openff-toolkit#888, I investigated adding tooling to simplify the use of the examples, and we discovered that they were not distributed with the toolkit by Conda. This PR adds a new subpackage,openff-toolkit-examples
, that includes the examples themselves as well as depending on the packages required to run them. In the future, this package may also include a helper application to run the examples, but using this packaging method allows us to let Conda manage package management.Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)