Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable automerge #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable automerge #104

wants to merge 2 commits into from

Conversation

traversaro
Copy link

@traversaro traversaro commented Sep 22, 2024

Given all the problems occurring in new pybind11 releases related to abi changes (see #95) perhaps it could make sense to disable automerge here so that new versions can at least be checked before merging?

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Author

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 2, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12118772517. Examine the logs at this URL for more detail.

@traversaro
Copy link
Author

I refreshed this PR as all the changes in pybind/pybind11#4953 and pybind/pybind11#5439 will require to revise the pybind11-abi package. However, after I opened it I noticed that the pybind11-abi package output was disabled in #108, so this is much less urgent, even if it would be great if we could solve rethink the pybind11-abi meta-package during the packaging of the new pybind11 release, as it is quite used across conda-forge: https://github.com/search?q=org%3Aconda-forge%20pybind11-abi&type=code .

The re-rendering does not change the content of the package, so I think we can avoid bump the build number.

@traversaro
Copy link
Author

@conda-forge/pybind11 the PR is ready for review/discussion.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants