Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add maximum numpy version at 1.24 #31

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Add maximum numpy version at 1.24 #31

merged 4 commits into from
Feb 2, 2023

Conversation

pbeaucage
Copy link
Contributor

@pbeaucage pbeaucage commented Feb 2, 2023 •
edited
Loading

Address SasView/sasview#2418 (incompatibility of sasview 5.0.5 with numpy 1.24 and greater) by adding an upper bound version pin in the recipe.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@pbeaucage
Add maximum numpy version at 1.24
5f71910 
(sasview\sasview#2418)
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pbeaucage
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits February 2, 2023 20:52
@pbeaucage pbeaucage marked this pull request as ready for review February 2, 2023 22:03
mrakitin
mrakitin approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for now until the newer version is released.

@mrakitin mrakitin merged commit 8d1fada into conda-forge:main Feb 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

@mdoucet mdoucet Awaiting requested review from mdoucet mdoucet is a code owner

@rozyczko rozyczko Awaiting requested review from rozyczko rozyczko is a code owner

@stuartcampbell stuartcampbell Awaiting requested review from stuartcampbell stuartcampbell is a code owner

@wpotrzebowski wpotrzebowski Awaiting requested review from wpotrzebowski wpotrzebowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbeaucage @mrakitin