Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sasview 5.0.6 - pre release testing #33

Merged
merged 6 commits into from
Apr 6, 2023

Conversation

wpotrzebowski
Copy link
Contributor

@wpotrzebowski wpotrzebowski commented Mar 27, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Wojciech Potrzebowski added 2 commits March 27, 2023 15:23
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mrakitin
Copy link
Member

@conda-forge-admin, please rerender

@wpotrzebowski
Copy link
Contributor Author

@mrakitin has it already been rerendered or should I also do something else?

@pbeaucage
Copy link
Contributor

It rerendered in 760abfd, I believe. Should be good now. Worth noting that the tarball link is pointing to the rc1 tag so the version (and presumably the sha hash) will need to be updated on release of 5.0.6.

@wpotrzebowski wpotrzebowski marked this pull request as ready for review April 6, 2023 06:54
@wpotrzebowski
Copy link
Contributor Author

Thanks @pbeaucage. Yes, we will need to update to 5.0.6 once we are ready to release. We will also need to change bumps version as a new release is on its way (and 5.0.6 should be released with it).

@wpotrzebowski
Copy link
Contributor Author

How can I test if this build works? For 5.0.5 release candidates I was able to do install test version by: conda create -n sasview -c conda-forge python=3.9 sasview=5.0.4.post36 But I guess in order to be able to do this PR needs to be merged?

@mrakitin
Copy link
Member

mrakitin commented Apr 6, 2023

@mrakitin has it already been rerendered or should I also do something else?

@wpotrzebowski, it does not hurt to render it again to get the latest config files, etc.

@mrakitin
Copy link
Member

mrakitin commented Apr 6, 2023

@conda-forge-admin, please rerender.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/sasview-feedstock/actions/runs/4630880241.

@mrakitin mrakitin merged commit db86508 into conda-forge:main Apr 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants