Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add recipe for json5. #8629

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Add recipe for json5. #8629

merged 2 commits into from
Jun 25, 2019

Conversation

ian-r-rose
Copy link
Contributor

A python implementation of the JSON5 extension to JSON.

Checklist

  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vend other packages
  • Build number is 0
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/json5) and found it was in an excellent condition.

jakirkham
jakirkham reviewed Jun 25, 2019
View reviewed changes
recipes/json5/meta.yaml
home: https://github.com/dpranke/pyjson5
license: Apache-2.0
license_family: Apache
license_file: LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised upstream issue ( dpranke/pyjson5#25 ) about getting the license file included in the package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham

@jakirkham jakirkham merged commit bbfe912 into conda-forge:master Jun 25, 2019
@jakirkham
Copy link
Member

Looks good. Thanks @ian-r-rose! 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-r-rose @conda-forge-linter @jakirkham