Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add patch for PR #1064 #13

Merged
merged 2 commits into from
May 16, 2022
Merged

add patch for PR #1064 #13

merged 2 commits into from
May 16, 2022

Conversation

kkraus14
Copy link
Contributor

@kkraus14 kkraus14 commented May 12, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Adds a patch based on jbeder/yaml-cpp#1064 that addresses symbol export/import issues which is a blocker for my usage.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@kkraus14
Copy link
Contributor Author

@conda-forge-admin, please rerender

@kkraus14
Copy link
Contributor Author

@conda-forge-admin, please rerender

@kkraus14
Copy link
Contributor Author

@conda-forge-admin, please rerender

@kkraus14
Copy link
Contributor Author

@conda-forge/yaml-cpp I'm not sure if this is something we want to support, but the symbol visibility is incorrect in the 0.7 release and the chain of linked PRs have this resolved in the current top of tree which is not yet released. This patch brings in the fixes for the symbol visibility.

@allanleal allanleal merged commit 78f7055 into conda-forge:main May 16, 2022
@kkraus14
Copy link
Contributor Author

Thank you @allanleal!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants