-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
support miniforge-version: latest, add more architectures #140
support miniforge-version: latest, add more architectures #140
Conversation
Hi @bollwyvl the motivation was 32/64 bit installers |
Right, but why are they named like they are? As in, |
Cant recall :) |
Guess it's good to go! And hooray, no parsing (though the page is coming along over on conda-forge/miniforge#89) |
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: ./ | ||
id: setup-miniconda | ||
with: | ||
environment-file: etc/example-environment.yml | ||
miniforge-version: ${{ matrix.miniforge-version }} | ||
miniforge-version: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be miniforge-version: "latest"
to conform with miniconda-version: "latest"
or does that not matter here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't really matter EVER, as everything is a string in GHAYAML. my kingdom for some *
and &
anchors... we could likely normalize everything to not be quoted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole === 'true'
thing (and a lack of real schema semantics) is really tiresome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @bollwyvl :)
Happy New Miniforge 🎉 ! Turns out we can get
miniforge-version: latest
at a predictable (though slightly different) URL.https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/linking-to-releases
Questions
arch
inputs on the miniconda architectures? On the miniforge ones, not knowing what to put, i just made it a pass-through, but renamed the constant so we don't get them mixed up...Code changes
latest
URL scheme