Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

support miniforge-version: latest, add more architectures #140

Merged
merged 3 commits into from
Jan 2, 2021

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jan 2, 2021

Happy New Miniforge 🎉 ! Turns out we can get miniforge-version: latest at a predictable (though slightly different) URL.

https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/linking-to-releases

Questions

  • @goanpeca what's the motivation for the specific arch inputs on the miniconda architectures? On the miniforge ones, not knowing what to put, i just made it a pass-through, but renamed the constant so we don't get them mixed up...

Code changes

  • supports the latest URL scheme
  • fills out rest of architectures supported by miniforge (I guess for self-hosted runners)
  • docs
  • test

@goanpeca
Copy link
Member

goanpeca commented Jan 2, 2021

Hi @bollwyvl the motivation was 32/64 bit installers

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

the motivation was 32/64 bit installers

Right, but why are they named like they are? As in, ARM64 vs aarch64...

@goanpeca
Copy link
Member

goanpeca commented Jan 2, 2021

Cant recall :)

@bollwyvl bollwyvl changed the title [wip] support miniforge-version: latest, add more architectures support miniforge-version: latest, add more architectures Jan 2, 2021
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jan 2, 2021

Guess it's good to go! And hooray, no parsing (though the page is coming along over on conda-forge/miniforge#89)

steps:
- uses: actions/checkout@v2
- uses: ./
id: setup-miniconda
with:
environment-file: etc/example-environment.yml
miniforge-version: ${{ matrix.miniforge-version }}
miniforge-version: latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be miniforge-version: "latest" to conform with miniconda-version: "latest" or does that not matter here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't really matter EVER, as everything is a string in GHAYAML. my kingdom for some * and & anchors... we could likely normalize everything to not be quoted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole === 'true' thing (and a lack of real schema semantics) is really tiresome

Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @bollwyvl :)

@goanpeca goanpeca merged commit e23d871 into conda-incubator:master Jan 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants