-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix condaBasePath when useBundled is false, and there's no pre-existing conda #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf why did you remove the code for the mac case?
It seems like this change will break something. Could you confirm 🤔 ?
It's the same as |
I think not, and home dir might have been pointing somewhere else on mac, hence the hardcoded path. Could you please verify before deleting the code? Thanks |
With |
Ping on this |
How about running:
and committing the resulting updates so that the example runs actually test the changes proposed by this PR? |
32b7134
to
fa6bdf9
Compare
Thanks @goanpeca |
macos-13 doesn't include a bundled conda, which should be fixed by updating setup-miniconda to v3 conda-incubator/setup-miniconda#344 https://github.com/conda-incubator/setup-miniconda/releases/tag/v3.0.0 conda-incubator/setup-miniconda#299
Useful when using setup-miniconda with self-hosted runners without conda installed.