Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to Ruff tools, update pre-commit #558

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Sep 12, 2024

The aims of this PR are to switch to faster/modern Ruff-based lint and formatting tools, and to update the pre-commit workflow. Details:

  • Replace "black", "isort" and "flake8" with Ruff. Some of these rules are selected in pyproject.toml, and I think most others are enabled by default. But keep blacken-docs for now, with the black version updated.
  • Remove unused configuration files (and references in MANIFEST.in)
  • Remove deprecated fix-encoding-pragma which is replaced by pyupgrade/"UP" Ruff rule. Other changes from this rule are removing default "r" from open() statements
  • Update sort-simple-yaml to look for any "config.yaml" file (there wasn't any grayskull/pypi/config.yaml file). The change from this sorts keys in grayskull/strategy/config.yaml

@mwtoews mwtoews requested a review from a team as a code owner September 12, 2024 22:05
@marcelotrevisani
Copy link
Member

Thanks for that, I wanted to move to use ruff but I was always forgetting about it.

@marcelotrevisani marcelotrevisani merged commit 2c1caa2 into conda:main Sep 20, 2024
6 checks passed
maresb pushed a commit to maresb/grayskull that referenced this pull request Sep 20, 2024
* Switch to Ruff tools, update pre-commit

* Update .pre-commit-config.yaml

---------

Co-authored-by: Marcelo Duarte Trevisani <marcelotrevisani@users.noreply.github.com>
@mwtoews mwtoews deleted the switch-to-ruff branch September 20, 2024 13:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants