Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Render placeholders in menu_name #175

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 10, 2024

Description

I had forgotten to render placeholders found in the menu_name key. This fixes that behavior so folks can things like do "menu_name": "{{ DISTRIBUTION_NAME }} shortcuts" to customize the Start Menu directory.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 10, 2024
@jaimergp jaimergp marked this pull request as ready for review January 10, 2024 11:33
@jaimergp jaimergp requested a review from a team as a code owner January 10, 2024 11:33
@jaimergp
Copy link
Contributor Author

cc @marcoesters

Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I am wondering if the rendering should be happening inside _load inside api.py

@jaimergp
Copy link
Contributor Author

jaimergp commented Jan 11, 2024

However, I am wondering if the rendering should be happening inside _load inside api.py

All the item rendering happens in the MenuItem instance. Directory creation also happens in the Menu class. I don't see how this would be beneficial 🤔

I'll merge for now and if necessary we can open a new PR.

Thanks!

@jaimergp jaimergp merged commit 5e4e8e7 into conda:main Jan 11, 2024
18 checks passed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Jan 11, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants