appkit-launcher only injected when event_handler is present #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
2 tasks
|
@jaimergp, tested locally and seems to be working as expected. Thanks! |
|
Good, as long as we get a review from @conda/constructor we are good to merge then. |
beeankha
reviewed
Feb 6, 2024
beeankha
reviewed
Feb 6, 2024
Co-authored-by: Bianca Henderson <beeankha@gmail.com>
beeankha
approved these changes
Feb 6, 2024
Merged
5 tasks
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #179
Some apps that their Apple events handler, so we don't need to inject our launcher. Decide by the presence of
event_handlerinstead ofCFBundle*keys.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?