Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add SingleMainWindow support #265

Merged
merged 7 commits into from
Nov 7, 2024
Merged

Add SingleMainWindow support #265

merged 7 commits into from
Nov 7, 2024

Conversation

larsoner
Copy link
Contributor

Closes #264, see description there.

Probably minor enough not to need a doc or test update? I just did git grep NoDisplay and added stuff in alphabetical order in the three places it showed up, hopefully that's good enough 🤞

@larsoner larsoner requested a review from a team as a code owner October 17, 2024 13:38
@conda-bot
Copy link
Contributor

We require contributors to sign our Contributor License Agreement and we don't have one on file for @larsoner.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1045), and ping the bot to refresh the PR.

@conda-bot conda-bot mentioned this pull request Oct 17, 2024
Merged
@larsoner larsoner mentioned this pull request Oct 17, 2024
Merged
5 tasks
@larsoner larsoner mentioned this pull request Oct 17, 2024
Closed
marcoesters
marcoesters previously requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@marcoesters marcoesters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a news file so that we can add this to the release notes easily. You can check out the news directory for the template and an example.

menuinst/_schema.py Outdated Show resolved Hide resolved
larsoner and others added 3 commits October 17, 2024 13:00
@larsoner @marcoesters
Update menuinst/_schema.py
2f7656c 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@larsoner
Document
dcbaf3e
@larsoner
Merge remote-tracking branch 'upstream/main' into smw
9a3832f 
* upstream/main:
  [pre-commit.ci] pre-commit autoupdate (conda#262)
  Bump actions/checkout from 4.2.0 to 4.2.1 in /.github/workflows (conda#261)
@larsoner
Copy link
Contributor Author

Thanks for the quick review, done @marcoesters !

@larsoner @marcoesters
Update news/265-add-singlemainwindow-support
7050614 
Co-authored-by: Marco Esters <mesters@anaconda.com>
@marcoesters
Copy link
Contributor

Thanks for the quick review, done @marcoesters !

Thanks for adding the file! I will approve as soon as your CLA goes through.

@jaimergp
Copy link
Contributor

jaimergp commented Nov 7, 2024

@marcoesters is the CLA still unreviewed? 🤔

@jaimergp jaimergp closed this Nov 7, 2024
@jaimergp jaimergp reopened this Nov 7, 2024
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 7, 2024
@jaimergp jaimergp dismissed marcoesters’s stale review November 7, 2024 11:26

CLA was approved

@jaimergp jaimergp merged commit 549e2b5 into conda:main Nov 7, 2024
30 checks passed
@mrclary mrclary mentioned this pull request Nov 10, 2024
Merged
5 tasks
@larsoner larsoner deleted the smw branch November 11, 2024 14:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@marcoesters marcoesters marcoesters left review comments

@jaimergp jaimergp jaimergp approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
🔎 Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SingleMainWindow support for Linux items
4 participants
@larsoner @conda-bot @marcoesters @jaimergp