-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for get all tables wildcard #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution @nickchomey!
Thanks! It still needs tests though And I suspect this PR will be superseded/made irrelevant by what we've discussed in #54. I know that somewhere there we discussed just using all tables by default if the includes is blank - similar to how gitignore works. Though I got inspiration for this wildcard from the Postgres connector, so perhaps it would be best to follow a similar pattern here? Whatever the case, I'd prefer to solve #54 first and implement tests there, then see if this one is still needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @nickchomey!
Hi @nickchomey! can you please update this PR and resolve the conflicts so we can go ahead and merge it, thanks! |
Sure, glad to hear you're still interested in it! I'll try to do it in the next day or so. I haven't touched conduit in a few months, so I'm looking forward to exploring the performance improvements and new cli. Will there be interest in the include/exclude regex patterns in #54? |
Ive merged the latest version of the connector to this PR. Let me know if you need anything else! |
Thank you @nickchomey !! 🚀 |
@nickchomey looks like CI is not happy about a couple of things. Seems pretty minor. Let me know if you need assistance
|
Head branch was pushed to by a user without write access
Ive resolved the gofumpt (an extra blank line) and I believe ive resolved the paramaterized query. Please let me know if you need anything else. |
Description
This adds support for specifying
"*"
in theconfig.Tables
field, which will then allow for snapshotting and syncing from all tables in the specified database.Fixes #29
Quick checks: