Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Moving base Confetti Framework components #140

Merged
merged 4 commits into from
May 21, 2022
Merged

Moving base Confetti Framework components #140

merged 4 commits into from
May 21, 2022

Conversation

octoper
Copy link
Contributor

@octoper octoper commented May 10, 2022

This PR removes the following import in favor of github.com/confetti-framework/framework

  • github.com/confetti-framework/contract
  • github.com/confetti-framework/foundation
  • github.com/confetti-framework/support
  • github.com/confetti-framework/validation

@octoper octoper requested a review from reindert-vetter May 10, 2022 21:26
Copy link
Contributor

@reindert-vetter reindert-vetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval, but maybe we should move github.com/confetti-framework/framework/contract/inter to github.com/confetti-framework/framework/inter (see other issue)

@octoper
Copy link
Contributor Author

octoper commented May 11, 2022

Okay I will try move it later today!

@octoper
Copy link
Contributor Author

octoper commented May 11, 2022

Just moved github.com/confetti-framework/framework/contract/inter to github.com/confetti-framework/framework/inter

@reindert-vetter
Copy link
Contributor

Very nice! Is there anything else that needs to be done? In that case, I'll test it today.

I will also refactor https://github.com/confetti-framework/commands to the framework repo. That's a stripped-down version of the confetti framework.

@octoper
Copy link
Contributor Author

octoper commented May 13, 2022

Νο everything is fine from my side.
The only thing remains is to create a readme and a contribution guide.

@reindert-vetter
Copy link
Contributor

Thanks! I will test and merge it today and tomorrow.

@reindert-vetter
Copy link
Contributor

reindert-vetter commented May 17, 2022

It all works fine 🥳 . I've also updated repo commands.

But baker doesn't work yet 😢 :

➜  confetti git:(framework) ✗ go run . baker
Baker  :help for help
 > app.Log().Info("test")
/Users/reindertvetter/go/pkg/mod/github.com/mattn/go-colorable@v0.1.7/colorable_others.go:10:2: missing go.sum entry for module providing package github.com/mattn/go-isatty (imported by github.com/mattn/go-colorable); to add:
	go get github.com/mattn/go-colorable@v0.1.7

I don't see how quickly I can solve the problem. Do you have an idea?

I've been busy updating repo baker with the upstream today. After resolving conflicts, tests fail in that repo, so I need to troubleshoot those further (see confetti-framework/baker#3)

@reindert-vetter
Copy link
Contributor

I think it works now. It must have been my environment. I'll merge it and make a release for it.

@reindert-vetter reindert-vetter merged commit 868d974 into main May 21, 2022
@reindert-vetter reindert-vetter deleted the framework branch May 21, 2022 21:49
@reindert-vetter
Copy link
Contributor

https://github.com/confetti-framework/confetti/releases/tag/v0.29.0 🥳

Thanks for all your work!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants