operator: Use latest operator image

[stevenhorsman]

Use the latest operator image in the default config as the base manage kustomization typically has the release tag and the release kustomization also has a release tag pinned, so we want to use default for
development and testing the latest operator after discussion with @mythi @fitzthum & @wainersm

[mythi]

In #488 (comment) I made the comment that the bundle build is a bit confusing. I remember we agreed the approach in this PR but the alternative would be to just make the bundle creation use config/release and make config/manager to use latest tag.

[stevenhorsman]

In #488 (comment) I made the comment that the bundle build is a bit confusing. I remember we agreed the approach in this PR but the alternative would be to just make the bundle creation use config/release and make config/manager to use latest tag.

Yep, that would also be completely valid. I think we'd need to update the bundle build process for that, but that's do-able

[mythi]

In #488 (comment) I made the comment that the bundle build is a bit confusing. I remember we agreed the approach in this PR but the alternative would be to just make the bundle creation use config/release and make config/manager to use latest tag.

Yep, that would also be completely valid. I think we'd need to update the bundle build process for that, but that's do-able

I'm OK either way. Thoughs @wainersm or others?

[wainersm]

Hi @mythi !

In #488 (comment) I made the comment that the bundle build is a bit confusing. I remember we agreed the approach in this PR but the alternative would be to just make the bundle creation use config/release and make config/manager to use latest tag.

Yep, that would also be completely valid. I think we'd need to update the bundle build process for that, but that's do-able

I'm OK either way. Thoughs @wainersm or others?

At this point you know more than me and so you are in better position to take a decision, so whatever you think it's better I should #.

Nevertheless, I'm trying to understand why we update config/manager on first place. The bundle is built out of config/manifests which includes config/release as well as config/samples/ccruntime/default. It seems wrong to include the later, isn't it? That's why it end up having to update config/manager?

[fitzthum]

LGTM

I don't have a strong feeling here but this seems like a straightforward approach.

[mythi]

The bundle is built out of config/manifests which includes config/release as well as config/samples/ccruntime/default

@wainersm this is what the Operator SDK scaffolding gives with the difference that we moved to config/release (vs config/default). to keep "devel" and "release" paths separate and make bundle creation purely release based, the alternative is

-       cd config/manager && $(KUSTOMIZE) edit set image controller=$(IMG)
+       cd config/release && $(KUSTOMIZE) edit set image controller=$(IMG)

with the one-time fix to drop newTag from config/manager/kustomization.yaml

[wainersm]

I suggest to merge this PR as is; @mythi can send an improvement on top of it if he wants to.

[stevenhorsman]

Ok, based on the approvals and discussion let's get this in and re-allow the installation of latest. If we want to re-work this later, then I'm happy to help.

[mythi]

Ok, based on the approvals and discussion let's get this in and re-allow the installation of latest. If we want to re-work this later, then I'm happy to help.

👍