Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: the json tag of the ImagePullSecret prefix should be lowercase #499

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

wangxf1987
Copy link
Contributor

@wangxf1987 wangxf1987 commented Feb 11, 2025

ImagePullSecret is modified to imagePullSecret

Signed-off-by: wangxiaofei67 <wangxiaofei67@jd.com>
@wangxf1987 wangxf1987 requested a review from a team as a code owner February 11, 2025 03:01
Signed-off-by: wangxiaofei67 <wangxiaofei67@jd.com>
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @wangxf1987

@huoqifeng
Copy link
Contributor

Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @wangxf1987

@fitzthum fitzthum merged commit f158c68 into confidential-containers:main Feb 11, 2025
19 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants