Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress, please do not merge yet.
For an example of CI result, see my build at https://travis-ci.org/phansys/PhpZabbixApi/builds/295154153.
I'm proposing to re-pack the build result into this repo, since it is intended to be used as an SDK for Zabbix API; so this library must act as a client independent from the Zabbix server / frontend.
The build will be kept as responsible of code generation, as you can see at the build matrix. The repo must have a branch in parallel with the Zabbix minor versions (
2.0
,2.1
,2.2
, ...) in order to guarantee BC while respecting semantic versioning.This PR is based on 2.4 version, so the build matrix executes the tests against the first release (
2.4.0
) and against the latest release (2.4.8
), in order to ensure there are no differences through patch releases. Please note this check is performed executing the build and confirming there are no differences with the existent code (withgit diff
).In this PR the autoload mechanism was upgraded too, from
classmap
topsr-4
.TODO:
Please, be free to share any thoughts or comments.