Fix duplicate message on validate offset #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation is discarded, not producing a duplicate
emasab
force-pushed
the
dev_fix_duplicate_message_on_validate_offset
branch
from
fe111b0 to
86caa97
Compare
milindl
approved these changes
Apr 20, 2023
emasab
added a commit
that referenced
this pull request
Apr 28, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate message can be emitted when a fetch response is received
in the middle of an offset validation request. Solved by discarding
the fetched message if the state is not
ACTIVE.