-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix for an idempotent producer error, with a message batch not reconstructed identically when retried #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructed identically when retried Issues: #4736 Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet". Happening on large batches. Solved by using the same backoff baseline for all messages in the batch. Happens since 2.2.0
milindl
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for this fix!
CHANGELOG.md
Outdated
@@ -3,6 +3,8 @@ | |||
librdkafka v2.5.0 is a feature release. | |||
|
|||
* Fix segfault when using long client id because of erased segment when using flexver. (#4689) | |||
* Fix for an idempotent producer error, with a message batch not reconstructed | |||
identically when retried (#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
identically when retried (#) | |
identically when retried (#4750). |
CHANGELOG.md
Outdated
identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet". | ||
Happening on large batches. Solved by using the same backoff baseline for all messages | ||
in the batch. | ||
Happens since 2.2.0 (#). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Happens since 2.2.0 (#). | |
Happens since 2.2.0 (#4750). |
Closes #4736 |
milindl
approved these changes
Jun 12, 2024
blindspotbounty
pushed a commit
to ordo-one/librdkafka
that referenced
this pull request
Oct 11, 2024
…tructed identically when retried (confluentinc#4750) Issues: confluentinc#4736 Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet". Happening on large batches. Solved by using the same backoff baseline for all messages in the batch. Happens since 2.2.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #4736
Fix for an idempotent producer error, with a message batch not reconstructed identically when retried. Caused the error message "Local: Inconsistent state: Unable to reconstruct MessageSet". Happening on large batches. Solved by using the same backoff baseline for all messages in the batch.
Happens since 2.2.0