Remove reader allocation for compressors pools #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small optimization to avoid allocating a new reader when recycling compressors by using `http.NoBody`. Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
akshayjshah
approved these changes
Oct 28, 2024
| @@ -147,7 +148,7 @@ func (c *compressionPool) putDecompressor(decompressor Decompressor) error { | |||
| // know the compression format, we can't provide a valid header. Since we | |||
| // also reset the decompressor when it's pulled out of the pool, we can | |||
| // ignore errors here. | |||
| _ = decompressor.Reset(strings.NewReader("")) | |||
| _ = decompressor.Reset(http.NoBody) | |||
There was a problem hiding this comment.
😻 Love the attention to detail here.
Merged
emcfarlane
added a commit
that referenced
this pull request
Jan 7, 2025
Below are the draft notes for the release: ---- # v1.18.0 ## What's Changed ### Enhancements * Add `package_suffix` option to `protoc-gen-connect-go` to allow specifying the output directory of generated code by @bufdev and @emcfarlane in #803 * Change stream client closures to be non-blocking by @emcfarlane in #791 ### Other changes * Fix comment typo spelling of optimize by @yoshihiro-shu in #786 * Remove reader allocation for compressors pools by @emcfarlane in #792 ## New Contributors * @yoshihiro-shu made their first contribution in #786 **Full Changelog**: v1.17.0...v1.18.0 Signed-off-by: Edward McFarlane <emcfarlane@buf.build>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to avoid allocating a new reader when recycling compressors by using
http.NoBody.