Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow ^2.0 of psr/container #57

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Allow ^2.0 of psr/container #57

merged 1 commit into from
Dec 14, 2023

Conversation

Biont
Copy link
Contributor

@Biont Biont commented Aug 24, 2021

Fixes #56

This seems to be pretty safe since the ServiceProviderInterface never actually interacts with ContainerInterface. Maybe you could even put @stable here, but I did not want to go that far

jakejohns added a commit to jakejohns/service-provider that referenced this pull request Jan 27, 2022
@jakejohns
Do not require psr/container as it is not used
3b74686 
Close container-interop#42
Close container-interop#56
Close container-interop#57
@jakejohns jakejohns mentioned this pull request Jan 27, 2022
Closed
@mindplay-dk
Copy link
Collaborator

Yes, this ought to be merged.

@mindplay-dk
Copy link
Collaborator

Can we get this merged and tagged, please?

With the most recent update, version 0.4 transitioned from container-interop/container-interop to the official psr/container, but it currently cannot be installed, as it conflicts with anything and everything requiring psr/container version 2.

Someone just needs to press merge and then add the 0.4.1 tag. (this is not a breaking change.)

@moufmouf @mnapoli anyone? 🙂

@moufmouf moufmouf merged commit e04441c into container-interop:master Dec 14, 2023
@moufmouf
Copy link
Contributor

Done! Thanks a lot and sorry for the loooooong merge time!

@XedinUnknown
Copy link
Collaborator

XedinUnknown commented Dec 15, 2023 •
edited
Loading

Sorry, I should have caught this, but it went under the radar. We could use some form of communication on this. Hit me up on Twitter if something needs expediting.

@Biont, thank you for this. I'd like to note, however, that @Dhii is moving away from this standard because nobody seems to be using it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not installable with psr/container ^2.0
4 participants
@Biont @mindplay-dk @moufmouf @XedinUnknown