Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xing-yang committed Nov 8, 2018
1 parent 17876f5 commit 8d99c5f
Show file tree
Hide file tree
Showing 3 changed files with 91 additions and 98 deletions.
10 changes: 4 additions & 6 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -773,10 +773,7 @@ message ControllerServiceCapability {
// CREATE_DELETE_SNAPSHOT MUST support creating volume from
// snapshot.
CREATE_DELETE_SNAPSHOT = 5;
// LIST_SNAPSHOTS is NOT REQUIRED. For plugins that need to
// process a snapshot after it is being cut, LIST_SNAPSHOTS
// COULD be used with the snapshot_id as the filter to query
// whether the processing is complete or not.
// LIST_SNAPSHOTS is NOT REQUIRED.
LIST_SNAPSHOTS = 6;
}

Expand Down Expand Up @@ -855,8 +852,9 @@ message Snapshot {
// field is REQUIRED.
int64 created_at = 4;

// Indicates if a snapshot is ready to use. The default value is
// false. This field is REQUIRED.
// Indicates if a snapshot is ready to use as a
// `volume_content_source` in a `CreateVolumeRequest`. The default
// value is false. This field is REQUIRED.
bool is_ready_to_use = 5;
}
message DeleteSnapshotRequest {
Expand Down
Loading

0 comments on commit 8d99c5f

Please # to comment.