-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Is VERSION file necessary? #324
Comments
Not a blocker for 1.0 |
so....if we remove the version file, where do we maintain a record of the current version? I had the notion that folks might consume VERSION in their build scripting, given that protobuf doesn't define it. If we were to come up with some solution for #170 then I'd agree that this file is unnecessary, but until then, I think if we get rid of it, we'd be forcing everyone to manually define the CSI version they are using, which seems a bid shady to me. |
I think version can be derived from the tag (e.g., v0.3.0, or v1.0.0, etc.) for releases? |
Now that CSI v1.3.0 has been cut: https://github.com/container-storage-interface/spec/releases/tag/v1.3.0 Bumping version for 1.4 release. We have to do this until #324 is resolved.
Follow up from #321 (comment)
Do we still need the VERSION file? If not, lets remove it.
The text was updated successfully, but these errors were encountered: