Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarify VolumeCapability and readonly on publish and stage #315

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Clarify VolumeCapability and readonly on publish and stage #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,11 +592,13 @@ message ControllerPublishVolumeRequest {
// field to match the node ID returned by `NodeGetInfo`.
string node_id = 2;

// The capability of the volume the CO expects the volume to have.
// Volume capability describing how the CO intends to use this volume.
// SP MUST ensure the CO can use the published volume as described.
// Otherwise SP MUST return the appropriate gRPC error code.
// This is a REQUIRED field.
VolumeCapability volume_capability = 3;

// Whether to publish the volume in readonly mode.
// Indicates SP MUST publish the volume in readonly mode.
// CO MUST set this field to false if SP does not have the
// PUBLISH_READONLY controller capability.
// This is a REQUIRED field.
Expand Down Expand Up @@ -954,7 +956,9 @@ message NodeStageVolumeRequest {
// This is a REQUIRED field.
string staging_target_path = 3;

// The capability of the volume the CO expects the volume to have.
// Volume capability describing how the CO intends to use this volume.
// SP MUST ensure the CO can use the staged volume as described.
// Otherwise SP MUST return the appropriate gRPC error code.
// This is a REQUIRED field.
VolumeCapability volume_capability = 4;

Expand Down Expand Up @@ -1013,12 +1017,14 @@ message NodePublishVolumeRequest {
// This is a REQUIRED field.
string target_path = 4;

// The capability of the volume the CO expects the volume to have.
// Volume capability describing how the CO intends to use this volume.
// SP MUST ensure the CO can use the published volume as described.
// Otherwise SP MUST return the appropriate gRPC error code.
// This is a REQUIRED field.
VolumeCapability volume_capability = 5;

// Whether to publish the volume in readonly mode. This field is
// REQUIRED.
// Indicates SP MUST publish the volume in readonly mode.
// This field is REQUIRED.
bool readonly = 6;

// Secrets required by plugin to complete node publish volume request.
Expand Down
Loading