Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

fix incomplete host device for PrivilegedWithoutHostDevices #1455

Merged
merged 1 commit into from
Apr 27, 2020
Merged

fix incomplete host device for PrivilegedWithoutHostDevices #1455

merged 1 commit into from
Apr 27, 2020

Conversation

thbtcllt
Copy link

For a privilege pods with PrivilegedWithoutHostDevices set to true
host device specified in the config are not provided (whereas it is done for
non privilege pods or privilege pods with PrivilegedWithoutHostDevices set
to false as all devices are included).

Add them in this case.

Fixes: 3353ab7 ("Add flag to overload default privileged host device behaviour")
Signed-off-by: Thibaut Collet thibaut.collet@6wind.com

@k8s-ci-robot
Copy link

Hi @thbtcllt. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thbtcllt
Copy link
Author

This change is linked to kata-containers/documentation#637

@thbtcllt thbtcllt mentioned this pull request Apr 21, 2020
Closed
mikebrow
mikebrow suggested changes Apr 21, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@mikebrow mikebrow mentioned this pull request Apr 21, 2020
Merged
@mikebrow
Copy link
Member

/ok-to-test

mikebrow
mikebrow approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Member

my bad on the first review... can you rebase please? I removed greetings from the test checklist.

fix incomplete host device for PrivilegedWithoutHostDevices
98f8ec4 
For a privilege pods with PrivilegedWithoutHostDevices set to true
host device specified in the config are not provided (whereas it is done for
non privilege pods or privilege pods with PrivilegedWithoutHostDevices set
to false as all devices are included).

Add them in this case.

Fixes: 3353ab7 ("Add flag to overload default privileged host device behaviour")
Signed-off-by: Thibaut Collet <thibaut.collet@6wind.com>
@mikebrow mikebrow added the lgtm label Apr 25, 2020
mikebrow
mikebrow approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 4ea4ca9 into containerd:master Apr 27, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@mikebrow mikebrow mikebrow approved these changes

Assignees
No one assigned
Labels
lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thbtcllt @k8s-ci-robot @mikebrow