-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix the rule of port allocate when executing -p multiple times for one command #2263
Conversation
HI, is any comments about this pr? |
lint is failing |
Please squash commits |
Thanks for the heads up, this is my first pr to a formal project and some of the features are not very familiar, did I succeed with the squash operation please? |
You can remove "Fix golint issue" from the commit message. |
…e command Signed-off-by: Eric Chan <tces1@hotmail.com>
Thanks, I have modified by your tips. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm merging this, but please consider adding an integration test
#2256
Fix public ports always assign to the same port numbe issue