Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the rule of port allocate when executing -p multiple times for one command #2263

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

tces1
Copy link
Contributor

@tces1 tces1 commented May 30, 2023

#2256
Fix public ports always assign to the same port numbe issue

@tces1 tces1 changed the title Fix public ports always assign to the same port numbe issue Fix the rule of port allocate when executing -p multiple times for one command Jun 8, 2023
@tces1
Copy link
Contributor Author

tces1 commented Jun 29, 2023

HI, is any comments about this pr?

@AkihiroSuda AkihiroSuda added this to the v1.5.0 milestone Jun 29, 2023
@AkihiroSuda
Copy link
Member

lint is failing

@AkihiroSuda
Copy link
Member

Please squash commits

@tces1
Copy link
Contributor Author

tces1 commented Jun 29, 2023

Please squash commits

Thanks for the heads up, this is my first pr to a formal project and some of the features are not very familiar, did I succeed with the squash operation please?

@AkihiroSuda
Copy link
Member

Please squash commits

Thanks for the heads up, this is my first pr to a formal project and some of the features are not very familiar, did I succeed with the squash operation please?

You can remove "Fix golint issue" from the commit message.
The "Signed-off-by" line should be in the last.

…e command

Signed-off-by: Eric Chan <tces1@hotmail.com>
@tces1
Copy link
Contributor Author

tces1 commented Jun 29, 2023

Please squash commits

Thanks for the heads up, this is my first pr to a formal project and some of the features are not very familiar, did I succeed with the squash operation please?

You can remove "Fix golint issue" from the commit message. The "Signed-off-by" line should be in the last.

Thanks, I have modified by your tips.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm merging this, but please consider adding an integration test

@AkihiroSuda AkihiroSuda merged commit ba23d5d into containerd:main Jun 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants