Fix nerdctl update --restart to make it work correctly
#2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
force-pushed
the
fix_update_restart_policy
branch
from
f8339fa to
a8e34b6
Compare
yankay
force-pushed
the
fix_update_restart_policy
branch
4 times, most recently
from
fe7ffa8 to
9b97d5a
Compare
AkihiroSuda
reviewed
Jun 21, 2023
| @@ -154,3 +155,28 @@ func TestUpdateRestartPolicy(t *testing.T) { | |||
| inspect := base.InspectContainer(tID) | |||
| assert.Equal(t, inspect.RestartCount, 2) | |||
| } | |||
|
|
|||
| func TestUpdateRestartPolicyOnRunned(t *testing.T) { | |||
There was a problem hiding this comment.
- In comment lines please explain how this is different from
TestUpdateRestartPolicy - "Runned" doesn't seem grammatically correct
There was a problem hiding this comment.
Thanks @AkihiroSuda for the PR review.
It function name has been changed , and add some comments
yankay
force-pushed
the
fix_update_restart_policy
branch
5 times, most recently
from
3f7c634 to
9b166c6
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
fix_update_restart_policy
branch
from
9b166c6 to
3a4938b
Compare
AkihiroSuda
approved these changes
Jun 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to fix the #2310
With the PR, the
restart.WithStatushas been added to the labels, so it can restart correctly.