-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Prepare 1.7.x #3422
Prepare 1.7.x #3422
Conversation
Bumps [github.com/containerd/accelerated-container-image](https://github.com/containerd/accelerated-container-image) from 1.0.4 to 1.1.2. - [Release notes](https://github.com/containerd/accelerated-container-image/releases) - [Commits](containerd/accelerated-container-image@v1.0.4...v1.1.2) --- updated-dependencies: - dependency-name: github.com/containerd/accelerated-container-image dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
d302774
to
58035fc
Compare
Related to [containerd#3310](containerd#3310) New behavior will always initialize a NetworkSettings entity for the inspect response, including Ports child member. If inspecting a running container with published ports, then all information will be correctly returned. If inspecting a running container without published ports, then NetworkSettings will include an initialized Ports member. If inspecting a stopped/exited container, then an entirely initialized, "empty-value" NetworkSettings is returned. Signed-off-by: Sam Chew <stchew@amazon.com>
58035fc
to
48824a7
Compare
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
@AkihiroSuda This test |
I think you can rollback the Docker version (v25? v24?) on the CI and call it a day Like this: |
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Bumps tonistiigi/xx from 1.4.0 to 1.5.0. --- updated-dependencies: - dependency-name: tonistiigi/xx dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
32641d4
to
3e7dbeb
Compare
That is because the tests and test suite are retried multiple times when they fail. |
55d6b14
to
eb9fcfb
Compare
Updated the golint version, it seems there are some undefined pkg, which doesnt seem to be correct, |
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
eb9fcfb
to
2df0c94
Compare
Updated golang & golinter will require additional fixes. Some were fixed here: https://github.com/containerd/nerdctl/pull/3321/files |
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
006599f
to
49be4c0
Compare
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
49be4c0
to
7cab42c
Compare
@AkihiroSuda / @apostasie Thanks |
@Shubhranshu153 hard work porting these... 👍 Went through the changes - looks good - and CI is green. Curious why the docker-compat testing suite got held back on ubuntu 22.04 - but then I don't think it matters. |
Not sure, in the main it was 22.04 so i kept 22.04. |
Considering the changes are ok, was wondering what are the next steps required for releasing it. |
Isn't it 24.04 on main? https://github.com/containerd/nerdctl/blob/main/.github/workflows/test.yml#L258-L259 (again, not a big deal anyhow, mere curiosity)
@AkihiroSuda (or other maintainers) for this ^. |
ah i see i was porting some commits and it had the comment and didnt notice it has been fixed, updating it |
40047c6
to
7cab42c
Compare
@apostasie Not updating the docker compat one to 24.04, seems stable release doesn't have a docker 24 release |
Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Updating dependencies for the release