Add nerdctl build --add-host option support #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pendo324
approved these changes
Dec 23, 2024
coderbirju
approved these changes
Dec 23, 2024
chews93319
approved these changes
Dec 23, 2024
|
@chews93319, yep good call out. Let me push another revision for this. |
austinvazquez
force-pushed
the
feat-build-add-host
branch
4 times, most recently
from
6a56dab to
054b633
Compare
This change refactors the parse extra hosts logic from container run command and adds support for image build add-host flag. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
feat-build-add-host
branch
from
054b633 to
f3f8310
Compare
|
@chews93319, I pushed 054b633 which refactors container run --add-host parsing logic into a utility function for host-gateway functionality. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for image build --add-host option to enable custom host-to-IP mappings.