-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Windows support for the synchronous shim #139
Conversation
bd3b938
to
dc59249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
Would be nice to add windows target to our CI to run tests on Windows
(and fix clippy/rustfmt complains)
💯 one of the tasks I have to take care to get this out of draft. Thanks for the quick response! |
c37f70f
to
59f358f
Compare
I've added a job for Windows. Since it only supports a subset of the workspaces right now, it is is own job. Also note until (containerd/ttrpc-rust#182 and containerd/ttrpc-rust#185) both merge the unit tests on windows are flaky. |
the ubuntu 20.04 failure doesn't look related:
|
I think this is ready for review, just waiting for a few merges and a release from ttrpc-rust which should be soon 🤞 . I will leave temporary commits and leave it in draft until then. |
db51ca4
to
14d0240
Compare
nothing major changed in the ttrpc version I had pinned and the released crate. Not sure if something else changed to cuase the integration tests to fail. I might split out the ttrpc verion upgrade anyways (not sure what this repositories standards are but that is generally asked for in other repos I've worked in). |
oh, looks like nightly CI started failing last week: https://github.com/containerd/rust-extensions/actions with the first failure in https://github.com/containerd/rust-extensions/actions/runs/5273246763 |
ttrpc 0.8.0 has been released! I've moved this from draft to ready for review.
@mxpv thoughts? |
Signed-off-by: James Sturtevant <jsturtevant@gmail.com> Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
Signed-off-by: James Sturtevant <jstur@microsoft.com>
ci is passing again after #148 |
Fixes: #4
This adds Windows support for the synchronous shim on windows. It builds on the support added to ttrpc-rust for Windows. It does require a couple updates (containerd/ttrpc-rust#182 and containerd/ttrpc-rust#185) and a release from that project.
Couple things to note:
command
implementation in this repository but does add some complexity to how the shim boots.cargo build
from root won't just work. This means a user would need to callcargo build
from the crate folders that do support windows (shim/shim-protos)Todo: