[windows] Unwrap error as windows error or otherwise return error message #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 24.39% 24.39%
=======================================
Files 17 17
Lines 2529 2529
=======================================
Hits 617 617
Misses 1912 1912
☔ View full report in Codecov by Sentry. |
When using raw_os_error it will return Some() if it is an OS error otherwise it will return None and the error isn't related to OS failure. This handles it there won't be a panic in the case of a non OS error. Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
remove-possible-panics
branch
from
5bdf781
to
57b2713
Compare
lifupan
approved these changes
May 6, 2023
wllenyj
approved these changes
May 6, 2023
quanweiZhou
approved these changes
May 9, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using raw_os_error it will return Some() if it is an OS error otherwise it will return None and the error isn't related to OS failure. This handles it there won't be a panic in the case of a non OS error.
feedback based on #185 (comment). Will need to rebase/update this once #182 #185 merge