Skip to content

Commit

Permalink
Merge pull request #1076 from lisongmin/main
Browse files Browse the repository at this point in the history
Fix unnecessary retrying when the link is down in dhcp
  • Loading branch information
squeed authored Aug 27, 2024
2 parents 5def332 + 0d2780f commit 3653221
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions plugins/ipam/dhcp/lease.go
Original file line number Diff line number Diff line change
Expand Up @@ -234,19 +234,19 @@ func (l *DHCPLease) getAllOptions() dhcp4.Options {
}

func (l *DHCPLease) acquire() error {
c, err := newDHCPClient(l.link, l.timeout, l.broadcast)
if err != nil {
return err
}
defer c.Close()

if (l.link.Attrs().Flags & net.FlagUp) != net.FlagUp {
log.Printf("Link %q down. Attempting to set up", l.link.Attrs().Name)
if err = netlink.LinkSetUp(l.link); err != nil {
if err := netlink.LinkSetUp(l.link); err != nil {
return err
}
}

c, err := newDHCPClient(l.link, l.timeout, l.broadcast)
if err != nil {
return err
}
defer c.Close()

opts := l.getAllOptions()

pkt, err := backoffRetry(l.resendMax, func() (*dhcp4.Packet, error) {
Expand Down

0 comments on commit 3653221

Please # to comment.