Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ip: include peer name in error message #1029

Merged
merged 1 commit into from
May 13, 2024

Conversation

samuelkarp
Copy link
Contributor

If makeVeth fails as a peer exists, the existing peer name should be included in the error message.

@qiutongs
Copy link

@jingyuanliang

pkg/ip/link_linux.go Outdated Show resolved Hide resolved
If makeVeth fails as a peer exists, the existing peer name should be
included in the error message.

Signed-off-by: Samuel Karp <samuelkarp@google.com>
@samuelkarp samuelkarp force-pushed the log-peer-veth-failure branch from 44814e7 to eb49a03 Compare April 26, 2024 22:49
@aojea
Copy link
Contributor

aojea commented Apr 28, 2024

/lgtm

@aojea
Copy link
Contributor

aojea commented Apr 28, 2024

ping @squeed @s1061123

Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR, @samuelkarp

@s1061123 s1061123 merged commit c053346 into containernetworking:main May 13, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants