Use stdbool.h for booleans #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't see any problem with it. |
We don't need to reinvent these, especially in a confusing form (bool type like stdbool.h, but TRUE and FALSE constants like GLib). stdbool.h was available in the gcc 4.6 that is the default compiler in Ubuntu 12.04, more than a decade ago, so it seems sufficiently ubiquitous. Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
pushed a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <will@williammanley.net> Signed-off-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <smcv@collabora.com>
rhendric
added a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <will@williammanley.net> Signed-off-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <smcv@collabora.com>
rhendric
added a commit
to rhendric/bubblewrap
that referenced
this pull request
Oct 15, 2024
This commit adds --overlay, --tmp-overlay, --ro-overlay, and --overlay-src options to enable bubblewrap to create overlay mounts. These options are only permitted when bubblewrap is not installed setuid. Resolves: containers#412 Co-authored-by: William Manley <will@williammanley.net> Signed-off-by: Ryan Hendrickson <ryan.hendrickson@alum.mit.edu> [smcv: Fix merge conflicts with containers#660] Signed-off-by: Simon McVittie <smcv@collabora.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to reinvent these, especially in a confusing form (bool type like stdbool.h, but TRUE and FALSE constants like GLib). stdbool.h was available in the gcc 4.6 that is the default compiler in Ubuntu 12.04, more than a decade ago, so it seems sufficiently ubiquitous.
cc @refi64