Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test/e2e: use ansible.builtin.shell for tasks that redirecting output. #209

Merged
merged 1 commit into from
Dec 18, 2023
Merged

test/e2e: use ansible.builtin.shell for tasks that redirecting output. #209

merged 1 commit into from
Dec 18, 2023

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Dec 18, 2023

We can't use ansible.builtin.command for tasks that create or update files by redirecting output. These all need ansible.builtin.shell instead.

@klihub
test/e2e: redirecting output needs builtin.shell.
74f21ad 
Use ansible.builtin.shell for tasks that try to write to files
by redirecting output.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from askervin December 18, 2023 13:37
askervin
askervin approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@askervin askervin merged commit c9ae08a into containers:main Dec 18, 2023
@klihub klihub deleted the fixes/e2e/use-shell-for-redirects branch December 19, 2023 08:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@askervin askervin askervin approved these changes

@fmuyassarov fmuyassarov fmuyassarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klihub @askervin @fmuyassarov