config-manager: improve systemd unit listing #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kad
reviewed
Dec 21, 2023
klihub
reviewed
Dec 21, 2023
klihub
requested changes
Dec 21, 2023
fmuyassarov
force-pushed
the
manager-unit
branch
from
e196d2d to
450c617
Compare
Don't rely on ListUnitsByPatternsContext method as it might be too new and missing in some of the distros like Amazon Linux 2. Instead filter out active units and then loop over those to check if either containerd or cri-o units exist. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
fmuyassarov
force-pushed
the
manager-unit
branch
from
450c617 to
fb3dd17
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on ListUnitsByPatternsContext method as it might be too new
and missing in some of the distros like Amazon Linux 2. Instead
filter out active units and then loop over those to check if either
containerd or cri-o units exist.