Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Podman v5 Quadlet .pod support for "ShmSize=" parameter #22915

Closed
poVoq opened this issue Jun 5, 2024 · 4 comments · Fixed by #24899
Closed

Podman v5 Quadlet .pod support for "ShmSize=" parameter #22915

poVoq opened this issue Jun 5, 2024 · 4 comments · Fixed by #24899
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. quadlet

Comments

@poVoq
Copy link

poVoq commented Jun 5, 2024

Feature request description

Quadlet .container files support the ShmSize= option, however when running a container in a Pod, the ShmSize needs to be set at the Pod level.

When manually creating a Pod via pod create -n example-pod -p 1234:1234 --shm-size=1g this works fine, however when creating a Quadlet .pod file, the ShmSize= option is not available.

As a work-around the PodmanArgs=--shm-size=1g option seems to be working though.

Suggest potential solution

Like on individual .container level, the ShmSize= option should also work in .pod files.

Have you considered any alternatives?

As a work-around the PodmanArgs=--shm-size=1g option seems to be working in a .pod file.

Additional context

It is a bit odd that --shm-size=1g needs to be set at the Pod level and doesn't work at the container level when running a container in a Pod, but unless this changed in Podman5 it still seems to be true.

@poVoq poVoq added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 5, 2024
@ygalblum
Copy link
Contributor

ygalblum commented Jun 6, 2024

Thanks for bringing this up. The PodmanArgs key was added for this exact reason - to workaround missing keys. Care to open a PR to add the support for .pod files?

@Luap99 Luap99 added the quadlet label Jun 6, 2024
Copy link

github-actions bot commented Jul 7, 2024

A friendly reminder that this issue had no activity for 30 days.

@Odilhao
Copy link
Contributor

Odilhao commented Jul 15, 2024

@ygalblum I can take a look and add this to .pod files, just stumbled on this while using .pod in my lab.

@ygalblum
Copy link
Contributor

@Odilhao, thanks for offering. I've assigned the issue to you. LMK if you need any help and/or tag me when you have the PR ready

Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 23, 2024
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
Odilhao added a commit to Odilhao/podman that referenced this issue Dec 30, 2024
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
Honny1 pushed a commit to Honny1/podman that referenced this issue Jan 13, 2025
This closes containers#22915

Signed-off-by: Odilon Sousa <osousa@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants