Skip to content

Update podman-secret-create.1.md #26083

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

itoffshore
Copy link
Contributor

Does this PR introduce a user-facing change?


None

@rhatdan
Copy link
Member

rhatdan commented May 6, 2025

LGTM

@mheon
Copy link
Member

mheon commented May 6, 2025

Docs LGTM but you have trailing whitespace

@itoffshore
Copy link
Contributor Author

itoffshore commented May 6, 2025

fixed - sorry about that ;o)

@TomSweeneyRedHat
Copy link
Member

@itoffshore one tiny change, otherwise
LGTM
TYVM!

* Adds example showing secure secret generation / rotation & mounting
* fixes containers#26064

Signed-off-by: Stuart Cardall <itoffshore@users.noreply.github.com>
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/approve

@mheon
Copy link
Member

mheon commented May 7, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2025
Copy link
Contributor

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, itoffshore, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1b55e39 into containers:main May 7, 2025
34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants