api: Don't HTML escape application/json responses #26432
Conversation
github-actions
bot
added
the
kind/api-change
stefwalter
force-pushed
the
dont-html-escape-json
branch
from
09dbbff to
5a95236
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, stefwalter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Added a test. It's more of a unit test, is that okay? |
An HTTP response with Content-Type application/json does not need to be HTML escaped. Doing this causes encoding issues in the Podman REST API output as seen in the issue: Fixes containers#17769 Remove the HTML escaping from Content-Type: application/json responses. Signed-off-by: Stef Walter <stef@thewalter.net> Co-Authored-By: Claude <noreply@anthropic.com>
stefwalter
force-pushed
the
dont-html-escape-json
branch
from
3db6dde to
cb4bf17
Compare
|
Thanks for the review @Luap99 . Made the requested changes, squashed. |
| // Verify the data matches what we sent | ||
| if !reflect.DeepEqual(parsed, testData) { | ||
| t.Errorf("Parsed message doesn't match original: got %v, want %v", | ||
| parsed["message"], testData["message"]) |
There was a problem hiding this comment.
this should be parsed, testData as we compare the full thing not just the one field. Otherwise if this ever fails the error message could be confusing since this shows something else then what the code matches.
An HTTP response with Content-Type application/json does not need to be HTML escaped. Doing this causes encoding issues in the Podman REST API output as seen in the issue:
Fixes #17769
Remove the HTML escaping from Content-Type: application/json responses.