Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Travis -> Cirrus: validate, vendor, and test #1249

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Travis -> Cirrus: validate, vendor, and test #1249

merged 2 commits into from
Apr 21, 2021

Conversation

cevich
Copy link
Member

@cevich cevich commented Apr 15, 2021 •
edited
Loading

Partial replacement for #1213 (does not migrate the problematic OSX-cross build)

Signed-off-by: Chris Evich cevich@redhat.com

@cevich cevich mentioned this pull request Apr 15, 2021
Closed
@cevich cevich force-pushed the travis_to_cirrus branch 2 times, most recently from e27d02c to f71a168 Compare April 15, 2021 19:43
@cevich
Copy link
Member Author

cevich commented Apr 15, 2021

Oof, well 💩 ! Things were running along fine, then ploP!

# $ podman --cgroup-manager=cgroupfs run -d --name reg -v /tmp/skopeo_bats.DNuIGc/auth:/auth:Z -p 5000:5000 quay.io/libpod/registry:2
# time="2021-04-15T15:00:48-05:00" level=error msg="User-selected graph driver \"vfs\" overwritten by graph driver \"overlay\" from database - delete libpod local files to resolve"
# 9760db076413233f2a16402c70188f52191256762d6d188ecc25174c85a93517
# /var/tmp/go/src/github.com/containers/skopeo/systemtest/helpers.bash: connect: No route to host
# /var/tmp/go/src/github.com/containers/skopeo/systemtest/helpers.bash: line 355: /dev/tcp/127.0.0.1/5000: No route to host

I don't remember hitting that when implementing the same test for c/image 😕

@cevich
Copy link
Member Author

cevich commented Apr 15, 2021

Indeed, same test in c/image, same images (I think) 2 days ago passed.

Harrumph!

@cevich
Copy link
Member Author

cevich commented Apr 15, 2021

@vrothberg have you seen this before? Any clue about the cause?

@vrothberg
Copy link
Member

@vrothberg have you seen this before? Any clue about the cause?

This could suggest that podman already ran before with VFS. A podman system reset may do the trick.

@cevich cevich force-pushed the travis_to_cirrus branch from f71a168 to 14c947a Compare April 16, 2021 12:52
@cevich
Copy link
Member Author

cevich commented Apr 16, 2021

This could suggest that podman already ran before with VFS.

Right, the integration tests ran prior to this and I find

integration/copy_test.go:       storage = fmt.Sprintf("[vfs@%s/root+%s/runroot]", storage, storage)

However while the unit and integration tests run inside a --privileged container, they don't volume-mount anything other than $GOPATH.

Also, other than not replacing the c/image sources, the failing Cirrus task is exactly the same as what's used there - where we don't have this problem. Suggesting it's some kind of rare race...that I happened to hit twice in a row.

Puzzling 😕

Trying again with a system reset as suggested...

@cevich
Copy link
Member Author

cevich commented Apr 16, 2021 •
edited
Loading

...hrmmm. Okay, it passed. Let's go with that then, and I'll add the same change to c/image CI.

@cevich cevich marked this pull request as draft April 16, 2021 13:23
@cevich
Copy link
Member Author

cevich commented Apr 16, 2021

Marked this as draft so I can work up a script to prevent lots of duplication w/ c/image automation.

@cevich cevich force-pushed the travis_to_cirrus branch 4 times, most recently from 93ed305 to 9a488a3 Compare April 16, 2021 18:40
@cevich cevich mentioned this pull request Apr 16, 2021
Merged
@cevich cevich requested a review from vrothberg April 16, 2021 19:03
@cevich cevich marked this pull request as ready for review April 16, 2021 19:03
@cevich
Copy link
Member Author

cevich commented Apr 16, 2021

Okay this is ready. Once it merges, I can finish up it's twin: containers/image#1202

@cevich
Copy link
Member Author

cevich commented Apr 19, 2021

Note to me: After this merges, need to adjust the branch-protection required status checks to include 'Total Success'.

@cevich cevich force-pushed the travis_to_cirrus branch from 9a488a3 to a6e4f70 Compare April 19, 2021 14:16
@cevich cevich mentioned this pull request Apr 19, 2021
Merged
@cevich
Copy link
Member Author

cevich commented Apr 19, 2021

(Rebased and force-pushed)

@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2021

LGTM
@vrothberg PTAL

vrothberg
vrothberg reviewed Apr 21, 2021
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cevich, can you do another rebase?

The changes LGTM

cevich added 2 commits April 21, 2021 09:55
@cevich
Travis -> Cirrus: validate, vendor, and test
146af8c 
Also add some basic setup commands to hack/get_ci_vm.sh

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Cirrus: Improve test synchronization with c/image
88979a6 
The `test_skopeo_task` must be substantially duplicated between this
repository and containers/image.  Make this easier to maintain by
implementing a runner script to contain any/all differences.  This
allows the `test_skopeo_task` definition to remain 100%
identical across the two repositories.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the travis_to_cirrus branch from a6e4f70 to 88979a6 Compare April 21, 2021 13:55
@cevich
Copy link
Member Author

cevich commented Apr 21, 2021

Rebased

@vrothberg vrothberg merged commit 5a3e8b6 into containers:master Apr 21, 2021
@vrothberg
Copy link
Member

Great work, @cevich !

mtrmac
mtrmac reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cevich I’m (very) slowly catching up, and I have some questions about the intent/trade-offs.

I’ll of course prepare PRs if necessary, at this point I’m primarily trying to learn how this works.

@cevich
Copy link
Member Author

cevich commented Jun 24, 2021

I’m (very) slowly catching up, and I have some questions about the intent/trade-offs.

oh this is great, I'm glad you're reviewing this. I'm just a wing-nut pushing buttons, so please don't be afraid to call me out.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@mtrmac mtrmac mtrmac left review comments

@vrothberg vrothberg vrothberg left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cevich @vrothberg @rhatdan @mtrmac