Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run (gofmt -s -w) #1427

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Run (gofmt -s -w) #1427

merged 1 commit into from
Aug 23, 2021

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Aug 21, 2021

Go 1.17 introduces a much more reasonable build constraint format, and gofmt now fails without using it.

Sadly we still need the old format as well, to support <1.17 builds.

Signed-off-by: Miloslav Trmač mitr@redhat.com

Go 1.17 introduces a much more reasonable build constraint format, and gofmt now fails without using it.

Sadly we still need the old format as well, to support <1.17 builds.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Aug 23, 2021

LGTM
@lsm5 @vrothberg PTAL

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac mtrmac merged commit 4fda005 into containers:main Aug 23, 2021
@mtrmac mtrmac deleted the go1.17 branch August 23, 2021 18:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants