Skip to content
This repository has been archived by the owner on Apr 3, 2018. It is now read-only.

display shim pid as an integer, not Mandarin Chinese #461

Closed
jodh-intel opened this issue Oct 30, 2017 · 6 comments
Closed

display shim pid as an integer, not Mandarin Chinese #461

jodh-intel opened this issue Oct 30, 2017 · 6 comments
Assignees
@jodh-intel

Comments

@jodh-intel
Copy link
Collaborator

... cough...

$ sudo grep -o "shim-pid=[^ ]*" /var/lib/clear-containers/runtime/runtime.log
shim-pid='伱'
shim-pid='九'
shim-pid='亀'
shim-pid='倧'
shim-pid='做'
shim-pid='僝'
shim-pid='兵'
@jodh-intel jodh-intel self-assigned this Oct 30, 2017
jodh-intel added a commit to jodh-intel/virtcontainers that referenced this issue Oct 30, 2017
@jodh-intel
shim: Display shim PID as an int
37ed32e 
Log the PID of the shim as an integer string rather than having the raw
int converted into a string (with undesirable and incorrect results).

Fixes containers#461.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel mentioned this issue Oct 30, 2017
Closed
@egernst
Copy link
Collaborator

egernst commented Feb 13, 2018

is this still an open issue? I haven't seen mandarin in a while...

@jodh-intel
Copy link
Collaborator Author

This was ultimately resolved by clearcontainers/runtime#787. Sniff... no more Mandarin 😢.

@grahamwhaley
Copy link
Contributor

這是一種恥辱

@jodh-intel
Copy link
Collaborator Author

我同意。

@laijs
Copy link
Collaborator

laijs commented Feb 14, 2018

哈哈

@gnawux
Copy link

gnawux commented Feb 14, 2018

I really like this, l feel like back to the Dos/Win98 days, 20 years ago :)

烫烫烫烫

@jodh-intel jodh-intel mentioned this issue Oct 17, 2018
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@jodh-intel jodh-intel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gnawux @laijs @grahamwhaley @egernst @jodh-intel